Matija Marohnić

Results 237 comments of Matija Marohnić

The solution is basically to memoize the ref created by `createRectRef` instead of the ternary above, which requires creating an additional component for rendering toast messages. You can see the...

Exactly like you said, I meant that the `// @flow` comment should be moved below the injected header instead of being _replaced_ by the header. What I want is this:...

> The similarity between strings is usually measured by hamming distance, which is pretty expensive to calculate for each header in a large codebase. Besides the time, I think settling...

Whitelisting comments is something that crossed my mind as well, but the example in https://github.com/Stuk/eslint-plugin-header/issues/16#issuecomment-356984727 wouldn't cover it, and it's a common case. I like the idea of not autofixing...

@Stuk I see what you meant by identifying special comments and prepending the header in those cases. Is it ok if I proceed with that? - if a file starts...

The user wouldn't have to think about a whitelist, I think the plugin itself would have it predefined. Concerning the rest of what you said, sure, the user could manually...

Yep, that could work! It's not ideal that the comment depends on the technology used, but it seems to be the most stable option so far.

That's great! It would be nice to be able to run `eslint --fix` for all files to automatically update all headers, but this plugin can't know for sure what the...

Actually, it can autofix in the case that the header comment matches `pattern`, otherwise it should use suggestions. I noticed that currently it's not possible to configure the rule to...

I would classify this as an ESLint issue. Sometimes you want some ESLint rules applied to some files, but not others, it doesn't only apply to eslint-plugin-header.