sh2

Results 154 comments of sh2

the only difference is: metrics for DP shall have label prefix named `envoy`, like: but nothing for CP.

If is possible, we can add `namespace` label for all the metrics from CP. xref: https://github.com/envoyproxy/gateway/pull/3393#issuecomment-2114028252

According to metrics collected by Grafana, this won't be a problem anymore, each metric contains, for example, `{__name__="watchable_depth", app_kubernetes_io_instance="eg", app_kubernetes_io_name="gateway-helm", control_plane="envoy-gateway", instance="10.244.0.6:19001", job="kubernetes-pods", message="httproute-status", namespace="envoy-gateway-system", node="kind-control-plane", pod="envoy-gateway-7ff7cffb6c-ll5dh", pod_template_hash="7ff7cffb6c", runner="provider"} `...

assign myself now, I will take a deeper look.

Hi, 我阐述一下初步的实现思路,若有不妥请指正。 `GetCrdMetadata` 方法不只在 `KubernetesOperator.AddWatcher` 中调用,在 `KubernetesOperator.RegisterWatcher` 方法中也有调用: https://github.com/opensergo/opensergo-control-plane/blob/91ef7e92e2745c646f294f248c5c4249ef488af2/pkg/controller/k8s_operator.go#L120-L139 也就是说在 `ControlPlane.handleSubscribeRequest` 之前,自定义的 CRDMetadata 就要被注册。 考虑到上述 handler 是在 `NewControlPlane` 时创建,并按注册顺序执行: https://github.com/opensergo/opensergo-control-plane/blob/91ef7e92e2745c646f294f248c5c4249ef488af2/control_plane.go#L37-L45 https://github.com/opensergo/opensergo-control-plane/blob/91ef7e92e2745c646f294f248c5c4249ef488af2/pkg/transport/grpc/server.go#L143-L149 所以可以在 `ControlPlane.handleSubscribeRequest` 这个 handler 注册之前,再注册一个用于检测自定义 CRDMetadata 的 Handler,其基本功能如下: 1....

Hi @nezdolik The metrics of EG are still work in progress, tracked by https://github.com/envoyproxy/gateway/issues/2092, for now, the latest version has support these metrics: - https://github.com/envoyproxy/gateway/blob/main/internal/message/metrics.go - https://github.com/envoyproxy/gateway/blob/main/internal/provider/kubernetes/metrics.go The usage of...

Done some research, couldn't find any tool like that. Since the metrics is not changed very often, maybe we could write a doc on our own.

will file a doc after https://github.com/envoyproxy/gateway/pull/3393 landed