gateway icon indicating copy to clipboard operation
gateway copied to clipboard

Consider moving away from promStatsdExporterContainer

Open arkodg opened this issue 1 year ago • 6 comments

Description:

Describe the issue.

https://github.com/envoyproxy/gateway/pull/2729 added support for enabling scraping prometheus metrics using a sidecar container based off prom/statsd-exporter:v0.18.0 . Pulling this image is tricky for air gapped clusters and adds another configuration point for syncing an extra image into a private registry

Can this be avoided if ratelimit introduced a prom endpoint natively, tracked with https://github.com/envoyproxy/ratelimit/issues/285

[optional Relevant Links:]

Any extra documentation required to understand the issue.

arkodg avatar May 10 '24 23:05 arkodg

hey @shawnh2 interested in investigating the feasibility of this one ? There's a PR linked to the above issue, unsure what's missing to get it through the finish line cc @zirain

arkodg avatar May 21 '24 20:05 arkodg

I cannot recall all the details last time I tried(it's long ago), most likely because https://github.com/lyft/gostats/pull/119 didn't merge to master.

zirain avatar May 22 '24 01:05 zirain

assign myself now, I will take a deeper look.

shawnh2 avatar May 22 '24 07:05 shawnh2

This issue has been automatically marked as stale because it has not had activity in the last 30 days.

github-actions[bot] avatar Jun 22 '24 04:06 github-actions[bot]

assign this to me

zirain avatar Jul 30 '24 01:07 zirain

xref: https://github.com/envoyproxy/ratelimit/pull/663

zirain avatar Jul 31 '24 14:07 zirain

xref: https://github.com/envoyproxy/ratelimit/pull/681

zirain avatar Sep 12 '24 04:09 zirain

looks like the ratelimit PR got merged !

arkodg avatar Sep 17 '24 21:09 arkodg