sean

Results 22 comments of sean

I'm on git version 2.37.2 and have the exact same two errors as @artis3n above with the `key::` inline format or the file location. I noticed that, with the latter,...

> Parallel bench test shows latency and throughput improvements of RLock are very significant for concurrent access. If the "new times" listed are using RLock, there's notable performance slowdowns in...

The `if ($r.length === 1)` was important long ago and I can't recall exactly why, but if multiple selectors match, it's an indication that it shouldn't run on the site....

On most mobile browsers, these would fire twice; once for `touchstart` and once for `click`, for example. I guess you wouldn't notice because the event handlers are safe to re-run...

Thanks for reporting that one. The site has a `splash-box` element that's set to 200% width, crazy! I'll see what I can do in the next update.

That's a good idea! Should it also have `aria-live="assertive"` for screen readers as well?

> the cloned element has a forced flex display That looks like exactly the issue! A display reset on the CSS for the modal would correct it, I think.

In the linked page it looks like they're using [Elementor](https://elementor.com/) and maybe Mediavine Creator or similar. Sadly, there is no ID to grab at the top level and only the...

I think the `#mv-create-wrapper` ID (probably created by Mediavine's content creation tool) might be too general to add because it might make the plugin work on non-recipe-pages. The JSON-LD solution...