Sam Gleske

Results 397 comments of Sam Gleske

Let me know when your'e ready for me to review/test this change for merging.

Please squash and rebase on master.

Thanks I'll look it over and test it.

Upgraded by uploading via the `Advanced` and checking the restart Jenkins checkbox. Jenkins threw a stacktrace upon upgrade. Click here for stack trace ``` java.lang.NullPointerException at com.thoughtworks.xstream.io.xml.PrettyPrintWriter.writeText(PrettyPrintWriter.java:235) at com.thoughtworks.xstream.io.xml.PrettyPrintWriter.writeText(PrettyPrintWriter.java:231) at...

However, when I restarted Jenkins the stacktrace went away.

I'm going to investigate this more before merging.

Also note, if you wanted to test this yourself without the complication of learning the scripts I publish packages of the version I tested. https://github.com/samrocketman/jenkins-bootstrap-jervis/releases/tag/jervis-bootstrap-2.89.4.3

@jdmulloy I just released a bunch of security fixes and a critical bug fix. Unfortunately, I didn't get a chance to test your change as part of the release. Would...

@jenkinsci/code-reviewers please take a look at this change. @Wadeck thanks for your help in other reviews. I really appreciate your efforts.