Rui Ueyama

Results 604 comments of Rui Ueyama

This patch LGTM, but let me wait until an upstream patch is accepted by the TBB folks. It shouldn't take too long. (I sent a patch to TBB to support...

We don't need to optimize the code in this file, so conservatively copy strings is fine. Generally, we should avoid optimizing code until it is proven to be a bottleneck.

In terms of performance, that doesn't make any measurable difference in this case. So it's more like a personal preference, and I feel conservatively copying strings is at least just...

`std::call_once` is used to make the thing that is protected by `call_once` thread-safe. In this case, `stop` is called by a single thread, so we don't need to use `call_once`.

It's a matter of personal preference, but I'm happy with the current indentation style. I don't think we need to vertically align variable names. As to `OS`, Android is Linux,...

Could you read https://github.com/rui314/mold/blob/main/CONTRIBUTING.md and add a `signed-off-by` line to your commit message?

This looks a bit too complicated -- it builds various targets on various hosts and downloads some tar file from other repo using `curl`. I think that just build mold...

It looks like CI failed. Can you take a look?

I think as long as the kernel provides the following features, we can implement the rest in the user space: 1. An interface to register a memory region in which...

I wonder if @MaskRay is interested.