mold icon indicating copy to clipboard operation
mold copied to clipboard

Add Nix CI

Open piegamesde opened this issue 4 years ago • 5 comments

Let me know what you think. Closes #81

piegamesde avatar Jul 10 '21 17:07 piegamesde

Obviously, every change to the source will result in having to rebuild everything. However, at the moment, the whole repository is marked as source. This means that even non-code changes or build artifacts will trigger a rebuild. This is not a real problem for the CI, but may be annoying when doing local development.

Having the relevant sources in one folder would make it a lot easier to only select source files for the build input.

piegamesde avatar Jul 10 '21 17:07 piegamesde

Thanks for the review. The hashes are indeed a problem. People are already working on this, see for example https://github.com/NixOS/rfcs/pull/62, but it's a really hard problem so it will take some time.

My packaging of mold was mostly copied from an earlier version of the nixpkgs packaging PR. I pinged you there, please have a look at it.

piegamesde avatar Jul 11 '21 11:07 piegamesde

It looks like CI failed. Can you take a look?

rui314 avatar Jul 14 '21 16:07 rui314

Silly mistake, I should have tried it out locally. It's a bit annoying that you have to enable the CI for my PR every time I push :(

piegamesde avatar Jul 14 '21 16:07 piegamesde

@piegamesde I simply submit a PR to my own fork to test, that way I don't have to wait on approval during testing.

nehaljwani avatar Jul 14 '21 17:07 nehaljwani