node-memwatch icon indicating copy to clipboard operation
node-memwatch copied to clipboard

Use Node.js 8 as a minimum engine version

Open dyatko opened this issue 7 years ago • 6 comments

dyatko avatar Jul 17 '18 12:07 dyatko

@eduardbcom If this package would work with Node v8, this PR would be very much appreciated.

alexilyaev avatar Aug 06 '18 14:08 alexilyaev

@dyatko Why not go even lower? Since this is a fork of the original memwatch, it should support as low as 0.8.0.

rochdev avatar Aug 10 '18 14:08 rochdev

@rochdev I have no clue. I just needed to get it to work with Node.js 8, which is the current LTS.

dyatko avatar Aug 10 '18 14:08 dyatko

@dyatko Fair enough :) BTW I found this one that is already updated: https://www.npmjs.com/package/@airbnb/node-memwatch

rochdev avatar Aug 10 '18 19:08 rochdev

What is going on with this ? yarn --ignore-engines seems to prove that this works fine with 8.X .

nmccready avatar Sep 26 '19 19:09 nmccready

Is there something in particular that possibly makes it not work with 8.X? Also, one big downside of @airbnb's fork is the loss of leak (leak event) detection.

nmccready avatar Sep 26 '19 19:09 nmccready