Cristian Morales Vega

Results 57 comments of Cristian Morales Vega

> We definitely do want `gsl::span` bounds check to unconditionally be enabled and unconditionally fail-fast on violation. > Giving `gsl::span` special treatment feels a little awkward. libstdc++'s std::span bounds check...

> Should the rule be less prescriptive and simply say something like "Clearly differentiate between preconditions of a method and the logic of the method"? I would agree https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Ri-expects is...

So, * In the initial checkin of the Guidelines (https://github.com/isocpp/CppCoreGuidelines/commit/947cf3af#diff-feb71ecadc563b52e66838adbd6b8e30R10906) from 14 Sep 2015 "??? `Expect` in under control of some options (enforcement, error message, alternatives to terminate)" was added....

We have an "Editors' call" from Herb and an action based on Jordan's interpretation of it. The only question is whether that interpretation is correct, and @hsutter is the only...

> if you #include , you can use std::size_t, if you #include , you can use size_t Is this what the standard says? (I had a quick read now and...

gst-inspect faac indeed shows that there is no profile property in the faac element. But I neither see it in the code: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/ext/faac/gstfaac.c It looks like a problem in arista...

OK, it's a property of the source pad, I didn't look there. But in such a case a gst-inspect shows the element provides it. It's really difficult to me to...

OK, I actually looked in the correct place before. The problem is this commit: http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/ext/faac/gstfaac.c?id=6702de4237f6e7c3166b2807150669557220c44f Arista doesn't work with the latest version of the faac element. I don't really know...

To finish it. 0.10.23 was the first version of gst-plugins-bad to include this change. And to make it work, instead of "faac bitrate= profile=LC", "faac bitrate= ! audio/mpeg, base-profile=lc" must...

Given ``` $ ./catch_test -s ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ catch_test is a Catch v2.13.7 host application. Run with -? for options ------------------------------------------------------------------------------- Factorials are computed ------------------------------------------------------------------------------- catch_test.cpp:34 ............................................................................... catch_test.cpp:39: PASSED: REQUIRE( Factorial(1) ==...