Fabian Lopez
Fabian Lopez
/sig contributor-experience /sig k8s-infra
@petr-muller I'm not sure if the issue you are referring to is the lack of filtering GitHub runs by PR which was the main issue to solve for https://github.com/kubernetes/test-infra/pull/24726 fortunately...
I think this could be accomplished by a new GitHub action that checks for the addition of the ok-to-test tag and copy the action to the necessary repos via knobots...
I'm making good progress on this [here](https://github.com/shinigambit/serving/pull/4) but I've hit a roadblock because at every attempt to approve I get the following message ```json {"message":"Resource not accessible by integration","documentation_url":"https://docs.github.com/rest/reference/actions#approve-a-workflow-run-for-a-fork-pull-request"} ```...
@upodroid the post you linked is very informative but also suggests using an `on:workflow_run` action to circumvent the token limitation. Do you feel strongly in favor of Prow or is...
It definitely should be possible to do it in Prow but the GitHub actions approach seemed easier to implement for me
That's fair, I'm not sure if a Prow job would do, seems a bit easier than making a plugin. Mind if I try that option first @dprotaso ?
Consensus in the productivity WG meeting is to open an issue in upstream Prow and have Prow take care of approving the GitHub workflow runs, let's explore that first @dprotaso...
> It also looks like the approval needs to occur any time there's a new change (ie. pushed a commit) on the PR. That's a bit worrying because we would...