Peter Meyers

Results 15 comments of Peter Meyers

> @pm-dev: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ Done

> @pm-dev Does that help explain why this is the way it is? What is the use case you're trying to fix here? @designatednerd Thanks for the quick reply and...

I was also surprised to find the result handler is not called on cancellation. Always having the completion handler called is a requirement if clients want to wrap [operations to...

I'd also support relaxing type checking. I'm using an [orm library](https://github.com/Syncleus/Ferma) where concrete types of data objects are created at runtime. When these objects are returned from a resolver, graphql-java-tools...

That approach sounds reasonable and would satisfy my use-case. FYI this is the workaround I was using https://github.com/pm-dev/graphql-java-tools/commit/ac43f74e224f7017f6f17cc17cc2e657f9e7b1e9 It's un-ideal because it changes the `getType` method from O(1) to O(n)...

@primeviltom glad you found the fix. `ImageAndVideoSlideshowDataSource.Source` is an enum that needs to wrap the video or image source: ``` public enum Source { case image(ImageSource) case av(AVSource) } ```...

Thanks for the reply. I've sent over a project which will allow you to repro.

@AnthonyMDev Thanks for the update! We certainly have a lot of nested fragments, which I consider a gql anti-pattern. For context, our app switched from REST to GQL while keeping...

Ah this makes sense, we're currently not merging fragment fields. Although merging in fields makes working with the data types more fluid, for our use-case where we are immediately translating...