Philip Langer

Results 144 comments of Philip Langer

@msujew Thank you very much for your detailed review and your great feedback! :+1: Good idea to test the disposal of the terminal link provider registration! I've enhanced the VS...

I've kept the changes for your suggestion in a separate commit c99474d to make it easier to review incrementally. Once you approve, I'm happy to squash and rebase. I'll likely...

[5f11e46](https://github.com/eclipse-theia/theia/pull/11552/commits/5f11e46ca7ca2ba3b3974e353956df24cf474f0b) rebases this change to include the changes of https://github.com/eclipse-theia/theia/pull/11398 and also squashes all commits of this PR.

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=24248 (Status: NEW)

https://github.com/eclipse-theia/theia/commit/a7992c4fdbc207cfc080b7567b43600da5e1f84e just rebases and resolves conflicts. Still waiting on https://dev.eclipse.org/ipzilla/show_bug.cgi?id=24248

@msujew [The CQ](https://dev.eclipse.org/ipzilla/show_bug.cgi?id=24248) has now been resolved. So I rebased this change and retested everything. Seems to be still fine after resolving some minor conflicts. PS: Please note that I...

@msujew Thank you for your review! I added a line to the changelog as you suggested, rebased the change on current master and gave it another quick test. :+1:

That's an interesting problem! :-) I might not have the full picture, but maybe my initial thoughts help: 1. I'm wondering whether this really is a bug after all. There...

Thank you very much for your feedback @rsoika! I get your points and we need to ensure that GLSP eventually supports those use cases. Given that GLSP is a framework...

> The main advantage of this is that ensures that the client side feedback is consistent with final route after the server update. If we would only adapt the handling...