Philip Langer

Results 144 comments of Philip Langer

Sounds like a good idea in general, however, I think we need to more clearly define the exact use case of reuse in other components (ie which interfaces and types...

Sure why not! I never created a flatpack package. If you'd like to provide a script to do that, I'd be more than happy to accept a PR. Thanks in...

I've never tested the MacOS build (I don't have one) and I'm not sure what's wrong, unfortunately. :/

@colin-grant-work Thank you for your fast reply! > Is this behavior correct? Should the default be not showing the terminal, or should we in fact be showing terminals that are...

I've rebased this change to resolve the conflict with #11641. @colin-grant-work I've written my answers to your comments [above](https://github.com/eclipse-theia/theia/pull/11630#issuecomment-1235840659). It'd be great if you could let me know what you...

Thanks a lot @vince-fugnitto for testing the change! @colin-grant-work Do you have further feedback?

@vince-fugnitto Thanks for the review! I pushed another update to address your feedback, see also [my comment](https://github.com/eclipse-theia/theia/pull/11630#discussion_r994356609) above.

Reminder to myself: Consider https://github.com/eclipse-theia/theia/pull/11398 after that PR has been merged!

@msujew Yes, that's correct! Thanks for the info! I've updated the description.