Radim Řehůřek
Radim Řehůřek
OK. Loading from 3.8.3 should work, that's the last release before 4.0.0. @gojomo can you think of what's wrong here?
Never mind tests; I can see no migration code in `Doc2Vec.load()` at all. Am I missing something? Of course having automated tests for loading older versions would be great, but...
I'd prefer you add the attribute migration to `load` (open a PR), so we can make a bugfix release.
Thanks. Where is that warning shown? If some extensions are being built with an incorrect language level, that sounds dangerous. CI is failing though.
`language_level` is about the level of Python (2 vs 3), right? Not Cython, which works with either. So we should have `language_level=3` everywhere in Gensim. Unless I'm missing something.
Hmm, the CI errors complain about syntax stuff in the Cython code like `gensim/models/fasttext_inner.pyx:187:9: 'REAL_t' is not a type identifier`. Which is unrelated to py2/3 IMO, weird. Will need a...
The problem seems to stem from this code: https://github.com/RaRe-Technologies/gensim/blob/5a19dd0407577001bcc177166582da7a5a4e5f70/gensim/models/word2vec_inner.pxd#L125-L126 which seems indeed syntactically broken: ``` cdef init_w2v_config(Word2VecConfig *c, model, alpha, compute_loss, _work, _neu1=*) ^ ------------------------------------------------------------ gensim/models/word2vec_inner.pxd:126:82: Expected an identifier or...
My hypothesis: error is related to the compilation order of Gensim extensions. 1. `fasttext_inner.pyx` depends on `word2vec_inner.pyx` 2. But with `language_level=3`, the `fasttext_inner.pyx` gets cythonized first => failure. 3. Under...
OK I think I figured it out. The issue is with relative imports (`from word2vec_inner import …`) in these pyx/pdx files. After changing them to absolute (`from gensim.models.word2vec_inner import …`)...
Hm, I get a permission error when I try to push to your branch directly (usually possible for maintainers across forks but maybe you disabled this). And github doesn't let...