Radim Řehůřek
Radim Řehůřek
Sounds good to me, thanks. After the replacement, can you do a sanity check re. performance? The new code should be faster (or at least not slower) than the existing...
> Should I include the sanity test file in the PR? Or is a screenshot of the results enough? A summary of your benchmark as part of the PR description...
I think the functionality is useful, but maybe too specific. This would be a better fit as a stand-alone extension (Python package), not in core gensim. Also for maintenance reasons.
Thanks. I do see value in better evaluation functions. My main worry is we have several already, with various parameters, and it's chaos for users. So to me this is...
-1 from me on all points: - If a bad actor gains access to the repo, we're screwed anyway (python packages always execute arbitrary code) - Why do you think...
If I understand you correctly, you'd like the code delivered separately (installed via `pip install`, followed by `api.load()`) as opposed to together (current, just `api.load()`). As long as the releases...
> It should just be discontinued ASAP - especially if there are no current maintainers eager to fix its issues. That's the option 3) I guess. That option (with a...
The difference between such version of `replace` and actually rearchitecting seems sufficiently small that it probably makes sense to got the full way: add some API / process to load...
> No users seems to be clamoring for a Gensim-specific dataset library, either in the form of gensim.downloader as it exists, or some vaguely-specified future version. It's unclear if anyone...
> That's useful info; I'd been looking for stats & couldn't find them. I googled up [this](https://githubstats0.firebaseapp.com/). The stats difference between `__init__.py` and its data asset file is interesting. I...