Petter Måhlén

Add kotlin-reflect on the builder classpath

6

The issue in #342 boils down to how Java classloaders and reflection in Kotlin work. Classloaders form a tree, where a classloader will first ask its parent for any requested...

Don't reformat 'javadoc' comments that appear before package/imports, to avoid mangling license headers

7

The use case is license headers added by, for instance, maven [license](http://www.mojohaus.org/license-maven-plugin/) [plugins](https://github.com/mycila/license-maven-plugin). These headers are not by default formatted in the way that google-java-format requires, and since neither (for...

## Bug description I was using the Navigate/Class function in Android Studio, had typed in a few characters, and hit return to go to the first search result when this...

Methods like `histogram`, `meter`, etc., are described like `Creates a new {@link Histogram} and registers it under the given name.`. This is incorrect, I believe, because in fact, if a...

This feels like a pretty obscure corner case, but in the following situation: 1. A Bazel package with mixed Java and Kotlin sources, where the Java code references the Kotlin...

Enable dumping KAPT processor performance stats

1

This enables passing the [dumpProcessorStats](https://kotlinlang.org/docs/kapt.html#measuring-performance-of-annotation-processors) flag to the KAPT invocation. Note that the official documentation uses the new name `dumpProcessorTimings`, which appears to be the name from version 1.8 onwards....

OptionalUnit conflicts with explicitApi=strict

11

## Expected Behavior It should be possible to enable [strict explicit API mode](https://kotlinlang.org/docs/whatsnew14.html#explicit-api-mode-for-library-authors) without getting conflicts with Detekt rules. ## Observed Behavior The OptionalUnit rule, if activated, considers an explicitly...

### Description of the bug: We occasionally see this error in CI: ``` java.lang.NullPointerException: Null lastCallTime at com.google.devtools.build.lib.worker.AutoValue_WorkerMetric_WorkerStat.(AutoValue_WorkerMetric_WorkerStat.java:21) at com.google.devtools.build.lib.worker.WorkerMetric$WorkerStat.create(WorkerMetric.java:51) at com.google.devtools.build.lib.worker.WorkerMetricsCollector.collectMetrics(WorkerMetricsCollector.java:224) at com.google.devtools.build.lib.profiler.CollectLocalResourceUsage.run(CollectLocalResourceUsage.java:179) ``` It appears to be caused...

Append Kapt stats if file exists

5

https://youtrack.jetbrains.com/issue/KT-55505 When running KAPT in a multi-module project, it's awkward to specify separate processor statistics dump files for each sub-module. This PR makes it so that previous statistics dumps are...

Fixes #1489