Peter Jaap Blaakmeer

Results 253 comments of Peter Jaap Blaakmeer

To make symfony/event-dispatcher work, I had to do some more fixes, which breaks BC with

@kezek I'm not working with this lib anymore, feel free to contribute!

The dependency for `magento/module-cron` in version 1.0.8 of this extension should be; `"magento/module-cron": ">=100.3.5"`

Right now, we just use an nginx rewrite; ``` location ~ ^/pub/media/catalog/(.*) { return 301 /media/catalog/$1; } ```

Here's the Magento issue (https://github.com/magento/magento2/issues/8868) and another workaround; https://magento.stackexchange.com/a/167878/237

@zaiatsFlagbit no I hadn't considered that. We're not using this extension anymore bytheway, @gaiterjones took over maintaining it.

Hmm I did a little bit of investigating and the code looks in the composer.lock file and uses that to compare. However, the composer.lock file does not hold any information...

Quick & dirty small diff that adds an asterix to direct dependencies; ``` diff --git a/composer-lock-diff b/composer-lock-diff index b665439..1ad1e4d 100755 --- a/composer-lock-diff +++ b/composer-lock-diff @@ -6,13 +6,15 @@ $opts =...

In what situation would omitting this cause an issue? I've never seen this being a problem and I don't think adding this is necessary so I'd love to hear why...