Peter Jaap Blaakmeer

Is vatcode an actual field? I thought Twinfield (ab)uses the `field4` field for this.

@cptX why shouldn't it?

Actually this is a bit harder than it seems; it would entail also triggering URL regeneration on updates on `status` and `visibility` fields to avoid conflicting (or non-existent) URLs.

Thanks @toonvd, it's still on my todo list to make that Magento PR better, but time & priorities, so I'm excited to see you picking this up for MageOS! :)

Wait, I think I found a bug. This line should read 'warnings', not 'errors'. And the next one should read 'fixable', not 'errors'; https://github.com/isaaceindhoven/php-code-sniffer-baseliner/blob/b6a3c1e4f64d9cb2d7d0ba676697c6ac1b3c9982/src/PhpCodeSnifferRunner/ReportDeserializer.php#L40 This causes the baseliner to skip...

LOL there already is a PR made SIX DAYS ago while this bug has been in here since January 2020! https://github.com/isaaceindhoven/php-code-sniffer-baseliner/pull/11

I just ran into this too and while you can run `phpcs` by appending the dir you want to scan to the command line arguments, it doesn't work that way...

I found some more issues. We run `phcps` through `grumphp`, which takes some configuration. This is the command Grumphp phpcs runs with; `Command: '/data/client/magento2/vendor/bin/phpcs' '--standard=./phpcs.xml' '--extensions=php,phtml' '--report=full' '--report-json' '--file-list=/tmp/phpijaJtq'` But...

Mabye it's an idea to pass on arguments given to `vendor/bin/phpcs-baseliner create-baseline` to the phpcs command in the runner?

@jeroennoten it's already on my Sunday funday open source list :)