Piotr Błażejewicz (Peter Blazejewicz)
Piotr Błażejewicz (Peter Blazejewicz)
https://github.com/angular/angular-cli/issues/11089
Can we also upgrade quide old content of the `angular-realworld-example-app/src/test.ts` to current test template? ```ts // This file is required by karma.conf.js and loads recursively all the .spec and framework...
Also, could the `main.ts` - as part of upgrade, be aligned with default template? ```diff diff --git a/src/main.ts b/src/main.ts index dd072d0..ba6abde 100644 --- a/src/main.ts +++ b/src/main.ts @@ -8,8 +8,6 @@...
LGTM :shipit:
We could probably send an dm to Thinkster, the CSS style should be open sourced as it begs for: - update (its' on BS 4 alpha) - fixes /cc @joeeames
@joeeames I'm really sorry for bothering you, I was wrong who to involve 🙇
@anishkny Can you ping me about this part of the project: https://github.com/gothinkster/conduit-bootstrap-template Thanks!
Just use TypeScript handbook as reference. AFAIK there is no rule in current Angular styleguide for constants/static variables conventions: https://www.typescriptlang.org/docs/handbook/enums.html There was a rule in older style guide though: https://v2.angular.io/docs/ts/latest/guide/style-guide.html#!#03-02...
@carballosa Sometimes that is OK to not unsubscribe (where the source of the observable will relinquish the resource). I've created a PR to put a context on this: https://github.com/gothinkster/angular-realworld-example-app/pull/153 The...
@lipis ping me if you need a hand. Thx!