Jay Patel

Results 5 comments of Jay Patel

I am still seeing this issue. @TonyLomartire did you do anything extra for building? I tried to do `npm update` and then `node-gyp build`. > ➜ msnodesqlv8 git:(master) ✗ node-gyp...

@TimelordUK I apologize for previous error logs as they were just a quote from few comments above mine. This is the error log for my computer and I think I...

It looks like @TimelordUK already applied your changes on master branch so basically this should work for me without changing anything. But it is not. This is the commit that...

Thank you. I think I found the bug and it is a missing comma in bindings.gyp file https://github.com/TimelordUK/node-sqlserver-v8/blob/master/binding.gyp#L142

@TimelordUK are you planning on adding this fix soon or would you like me to make a PR for you?