KuuwangE

Results 10 comments of KuuwangE

Same as xuhaomin0430 so quote that.. but i'm korean so when i use korean chracters it shows slow down but english is okay and for My case it was Occured...

Thanks For Review 👍🏻 that will be more better! i think it will be better not to use default merge sort function when user provide function and provide user can...

> Please grant me push access to your repo so that I can help you with the documentation. sure! invited!

@alex-courtis i've changed something! Can you review it again..?, I appreciate it.

> Questions I have: > > * Do we need to provide a comparator and a merge sort function? > * The input to a comparator can be sanitised by...

> > I thought provide well-made this repo's merge sort function will bring benefits to reduce users error caused by mistake > > That is thoughtful, however it adds complexity...

dear @alex-courtis, can i request one more review :) - there are have exclude settings. so if user function makes missing value, then just try original position to place -...

> All tested OK. > > > > I'm happy; if you're happy I will merge. excited to die, hhh

> All tested OK. > > > > I'm happy; if you're happy I will merge. thanksssss have a nice day!!!!

option 3 will be gooooooood