Nils Vindice

Results 12 comments of Nils Vindice

Is there any workaround...?

I see. Is there any way to get access to the `view` object in the plugin? This would be a very simple way to pass error messages.

Yes, I've noticed that. In our case, we will just go back to the 2018.x version and throw an exception (which seems to work fine here). However, this seems to...

Shouldn't the parameters be sanitized before they are used for URL generation and then cached? I don't care for unsuccessful hacking attempts, but I don't want them to be part...

We don't have a language/currency selection. URL: belago*de

Currently hopefully none, we cleared the cache and reset Google's index. Yesterday Google (!) listed a couple of pages like this: ``https://belago*de/c/Unsere_Beststeller~22?ai[currency]=EUR%22%27`--)&ai[locale]=de&ai[site]=default&currency=EUR%22%27`--)&locale=de&site=default``

What do you think of this solution altogether? It's not beautiful, because we have a lot of code duplicates here. However, the "order" methods might be too specific to add...

Sorry, I'm not able to write the tests right now. Most of the tests from `Omnipay` should work, as the methods are copied with minor adaptions. The `apiType = order`...

Well, we are using it in production without any issues - I'll try to build some tests in the next couple of weeks...

Writing tests is more work than expected, because `Omnipay/Dummy` does not support `orders`, as `Omnipay/omnipay-mollie` does. Not sure how to continue best, as I'm not used to work with PHPUnit...