Nicholai Main

Results 17 comments of Nicholai Main

Isn't this entirely up to the implementation of components that you're rendering? The point of `ReactDOM.createPortal` is to allow you to render content where the React VDOM hierarchy differs from...

It's been a while since I built something like this, but my general approach would be to render the menu in same component that renders the button, with no portal,...

Even when keys match and DOM elements are reused, in order to keep focus you either need to 1) avoid removing the focused element from the DOM, or 2) manually...

As I outlined in my previous response, the focus will automatically remain if you do not remove the element from the DOM. The vanilla example can easily be tweaked to...

How does an alternative file extension benefit you? If you're consuming other people's work that uses the normal extension, you'll still have the same issues.

I feel a lot of the blame is on the file explorer applications here: If you're going to make something that implicitly opens every single file and scans every single...

> this looks like exactly what we currently do with our PositionedOverlay that uses a portal component under the hood 👀 @chloerice You should be able to use `position: fixed`...

See this FAQ entry: https://github.com/microsoft/TypeScript/wiki/FAQ#indirect-excess-properties-are-ok

I personally would prefer not to see this change. The automatic coercion of non-strings to strings that exists in many DOM apis is very implicit and I like that typescript...

> `Object.prototype.test = function () {}` This adds an __enumerable__ property to every object in your entire JS context. In a normal JS environment, this is not the case; for...