Nicolas Franck

Results 140 comments of Nicolas Franck

@demiankatz no not really. None of the mentioned configuration settings have any effect. For reference: in v4.0.25 the settings have an effect, so the "change" must have been introduced since...

@demiankatz the main branch is some commits ahead, but those commits are more about adding readme sections, do not contain anything code related (right?). I did do a git-diff, but...

ah, I see now a merge of the dev branch into the main 8 hours ago.

@demiankatz that would be helpful. As I said, even if I run it, I do not know what I am looking at.

What I noticed: * the content-left-panel uses a different ThumbsView: https://github.com/UniversalViewer/universalviewer/blob/main/src/content-handlers/iiif/modules/uv-contentleftpanel-module/ThumbsView.tsx, one that is built with React? That one is different from https://github.com/UniversalViewer/universalviewer/blob/main/src/content-handlers/iiif/modules/uv-shared-module/ThumbsView.ts where cache invalidation is configurable (by adding...

Yes, a cache key that is reset after certain events, like login. I think that in UV3 the date stamps were added as a common way to prevent stale cached...

See https://github.com/UniversalViewer/universalviewer/pull/556

Variable `blank` is created on line https://github.com/DMPRoadmap/roadmap/blob/main/app/views/shared/export/_plan.erb#L40, but within an "if" statement. If that statement isn't executed, that variable does not exist, and what is worse: variable `answer` does not...

What happens now: on selection of guidance groups in the modal, the short view is updated also. But yes, the changes are not saved. But then again, nothing is saved...

On plan level, I would add a method `research_output_enabled?` that checks for global (by configuration) and local (by template) support.