Nat Noordanus

Results 83 comments of Nat Noordanus

Hi @DK99, thanks for working on this. > I analyzed the code a bit more. The problem why so many test fail is that currently the library doesn't know the...

It looks like we differ from the google implementation in this respect, so yes I'd say it is a bug. Thanks for reporting.

That seems odd, any insight? @danielgtaylor

Thanks for the detailed report. So the problem is that we call task_done based on the assumption that we got an item from the queue, but there might not have...

I think extracting the parsing logic to a cython compiled module would be a good first step. Writing an extension in rust might give better performance but isn't as good...

Hi @boukeversteegh, As far as branches are concerned, 2.x follows master, and all development effort has gone towards 2.x, so I think we're alright there. That said, there hasn't been...

The ideal solution for this would be a (breaking) change for nested enums to instead compile to nested classes in python instead of relying on naming concatenation.

The obvious workaround is to remove the code you don't want to from the generated files. That said I think it does make sense for betterproto to support this kind...

Similar issue: https://github.com/danielgtaylor/python-betterproto/issues/20

Hi @ShayNehmad-RecoLabs, thanks for working on this. Now that I see it explained like this, I'm curious if you tried doing `poetry uninstall betterproto; poetry install betterproto`, before just rebuilding...