Naseem comments

Results 109 comments of


                                            Naseem

OpenTelemetry integration misses the point: we need to propagate the span/context!

I came up with this as a workaround (there is a comment in the event listener about what I think this library should provide): ```js import {Message, PubSub} from '@google-cloud/pubsub';...

Manually removed backend does not add itself back

The only way for the autoneg controller to add them back is to delete the NEG-services and re create them

Remote sampling?

> no, this is a unique feature of Jaeger clients.

paymentsservice: structure logs

> please remove the hardcoded default port, the rest looks great. > > Thanks! done, my pleasure

fix: enforce no-explicit-any and no-unused-vars as errors

for unused vars, thoughts on `["error", { "argsIgnorePattern": "^_" }]` ? ref.: https://eslint.org/docs/rules/no-unused-vars#argsignorepattern

Replace | any with Partial<T> for type checking across all constructs

Sounds good, I'm happy to open a PR as well, just let me know!

Replace | any with Partial<T> for type checking across all constructs

Alright, I do not see how it would break anything as it would just disallow passing in props that are not present in the type (while making them all optional...

Replace | any with Partial<T> for type checking across all constructs

Thanks for the update @biffgaut

Replace | any with Partial<T> for type checking across all constructs

@biffgaut why was this closed? from your last message I was under the impression that after fixing the issue within JSII we would be able to use Patrial types, is...