opentelemetry-js

opentelemetry-js copied to clipboard

• [ ] This only affects the JavaScript OpenTelemetry library
• [x] This may affect other libraries, but I would like to get opinions here first

I want to have the sampling strategy configured at the Jaeger Collector as per https://www.jaegertracing.io/docs/1.16/sampling/#client-sampling-configuration ... this requires the client to have a "remote sampling" strategy. Is this possible today?

no, this is a unique feature of Jaeger clients.

Will this be implemented? Support for jaeger remote sampling has been added to the opentelemetry specification

See OTEL_TRACES_SAMPLER =jaeger_remote in the specification

Interesting. The SDK spec doesn't list the jaeger remote sampler as a built-in sampler. Maybe this is a spec oversight? https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#built-in-samplers

Can this issue be re-opened? I would like to have this functionality available.

Yes this issue can be reopened but it should likely be clarified in the spec if the jaeger remote sampler is a spec required component. If not, it would likely need to be implemented in the contrib repo.

The spec is now updated and mentions Jaeger remote sampler. https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#jaegerremotesampler

Are there plans to implement jaeger remote sampling feature for JS ?

Are there any plans to implement this?

The spec has now been clarified that the remote sampler is supposed to be included with an SDK implementation.

I opened a new issue that should be a bit clearer what needs to be done to fully implement the feature, and where in the repo to put it, see #4534. I'm closing this issue in favor of the new one. I marked the new one as up-for-grabs in case anyone stumbling across this issue wants to work on it.