Matt Craig

Results 215 comments of Matt Craig

I meant accepting a numpy array instead of a Table (not that it would stop accepting tables, just that one could provide a numpy array instead). I'll try to flesh...

Actually, the original implementation called for an Astropy stretch to be the value, I think it was turned into a string to get ginga working quickly, maybe?

After looking this over some more I think it makes sense to go with 3....or maybe even disallow strings.

I see in #126 that there is no restriction imposed on what stretch can be. It might be nice to be explicit about what is allowed, though.

> 👎 on disallowing string for Ginga though. I don't see the point to have to manually build an astropy.visualization object when I can just pass in a string to...

The bqplot implementation would probably use https://github.com/glue-viz/ipyastroimage as the Mark on the bqplot plot. That can take a numpy array, so I think we can avoid the conversion to another...

Found it, will upload soon (it had zero comments and didn't actually quite work 😮)

Look in this, don't judge the code too harshly 😀 https://gist.github.com/mwcraig/303cfb6e3e970d137e91789245ff259d You will need to change the image you are using, let me know if you need me to send...

@pllim -- not too much from what I understand. Maarten developed [ipyastroimage](https://github.com/glue-viz/ipyastroimage) as a more astronomy-centric replacement for the `Image` mark in bqplot because they needed that for the jupyter...

Would it be ok to start working on this next week (after Nov 7) -- I'm heading to a conference in a few days.