Matt Craig
Matt Craig
What size should these be drawn at do you think? I don't remember if these change size in matplotlib. Could add this to #1506 today.
Ah, so is the desire here just for a `.` that does that as a shortcut?
Also, should I make the shortcut for the crosshair "x" so that it matches matplotlib?
`.` has been added to #1506
> > so that it matches matplotlib? > Would be nice. 🐱 Done -- unfortunately, the shortcut `+` is already taken in bqplot and means an outlined plus sign so...
@ibdafna @pllim
@ibdafna -- I've addressed the review comments.
IIRC (and it has been a while) the reason for emitting a warning was to ensure the user was aware that they were overriding the unit already in the file....
> Oh I just realized that of course this is not a warning, it is a logger message Good point -- it would be easy enough to change the logging...
I'm pretty sure I decided based on this: https://docs.python.org/3/howto/logging.html#when-to-use-logging I'm fine with switching to warning if that is preferred.