Márk Tolmács

> I might be missing something, but should this PR update the githooks path? > > https://github.com/flutter/engine/blob/dbb5284f2c8d87473d60baa21bba0b7ab88c8281/tools/githooks/setup.py#L30-L32 Since that was the cause of the big miscommunication contributing to the rollback...

@loic-sharma Haha you're right, I confused myself along the way and this was missing. I added it now.

Added tests for `ci/bin/format.dart` in [460ad05](https://github.com/flutter/engine/pull/36123/commits/460ad0522be4e5c4ae689d48ba0deaa2920c88e3). Unfortunately the tests need to run in a serialized manner due to the fact that the formatting process cannot run in parallel. I solved...

Hi, if the tests are sufficient on this PR, can we remove the "needs tests" label? Also is there something else I need to do to get this merged? Thanks!

This is indeed a breaking bug, the C++ formatting patch clearly cuts off the end of the file before diffing. Let me investigate this. In the meantime, this should not...

For reference, this is the dartlang issue associated with this bug: https://github.com/dart-lang/sdk/issues/50904

Hi @Hixie yes. It's functionally complete, the only thing needs fixing is the output issue this is blocked on currently. I don't have any other ideas how this can be...

Yes, thanks, I'll check it in the next couple of days.

I checked it with the latest Dart build from the tree (--no-prebuilt-dart-sdk) and removed the deprecated hack + tested it on Windows (I still need to test it on Mac...

> > However the scripts hard-code the pre-built Dart SDK from the third-party directory, so we need to wait until the prebuild Dart SDK is updated to `3.1.0-189.0.dev`. I'm now...