Peter Johnson

Agh, I think I know what's going on! This is the line responsible: https://github.com/pelias/api/blob/master/routes/v1.js#L169 What's going on here is, if libpostal parsed the input and thinks it contains admin tokens...

I'm struggling to wrap my head around this, it all *seems* good to me but I don't really understand it. Can you please remind me what it's about? What I...

Oh this also requires a rebase to get the GH Actions tests working again

Yeah the whole findByIDs thing should have really been findWithinBoundingBoxes, it would allow more leniency.

Yeah at the moment there is no 'canonical list' of categories as such. The best we have so far is [the OSM mapping file](https://github.com/pelias/openstreetmap/blob/master/config/category_map.js) which is based on [my original...

I'm not familiar with the area but there is a [locality](https://spelunker.whosonfirst.org/id/101717347/) a [localadmin](https://spelunker.whosonfirst.org/id/404487689/) and a [county](https://spelunker.whosonfirst.org/id/102081337/) record for 'Warren'. I'm assuming that the issue is that the `county` isn't matching,...

this PR replaces https://github.com/pelias/api/pull/1554 which was much more complicated, this method is both easier to implement/test and also more accurate than string checking the various name fields.

hmm.. it should already be doing that, I'll have to pick this up again next week 🤔 https://github.com/pelias/api/pull/1580/files#diff-19d27b5d3dcbc72dfec62360afe0dbc154cc7ff03a30be725d3a8a6dee3df5afR181-R185

added via rebase ```diff diff --git a/helper/diffPlaces.js b/helper/diffPlaces.js index 840f0203..d11ef0ba 100644 --- a/helper/diffPlaces.js +++ b/helper/diffPlaces.js @@ -168,6 +168,9 @@ const parentGID = (item, layer) => { */ function isEquivalentIdentity(item1, item2)...

I noticed that queries for ordinal streets (such as `1st st`) can become noisier with this PR: The last 3 results are undesirable because they aren't what the user requested:...