Peter Johnson

Results 884 comments of Peter Johnson

as-is this PR is safe to merge since it's backward compatible.

Adding a couple of examples where two addresses with the same name are not quite at the same coordinates. These might serve as good test cases if/when this feature gets...

here? - https://github.com/pelias/api/blob/master/sanitizer/defer_to_pelias_parser.js#L21 - https://github.com/pelias/api/blob/master/routes/v1.js#L215-L224

I think the core issue is that the 'combining sanitizers' (such as https://github.com/pelias/api/blob/master/sanitizer/search.js) should return immediately upon error rather than running through the rest of the route chain.

ie. here https://github.com/pelias/api/blob/master/sanitizer/sanitizeAll.js#L94 it should return something to trigger the `err` in express middleware `(req, res, err)`.

wow, so actually, that's apparently a very common street name in Sydney, how confusing 😆 https://pelias.github.io/compare/#/v1/autocomplete?boundary.gid=whosonfirst%3Amacrocounty%3A1376953385&text=2+Macquarie+Street

Hey @Joxit I'm feeling less confident with merging this now, I like the improvements in Australia but it feels like it might come with a regression in France/Germany and any...

That's very odd, I can't imagine what would be causing it. We've had a few bugs reported with how the compare app handles encoding and decoding of the input box...

IIRC from when I did the PR for that, you should be able to simply write `&categories&` instead of `&categories=&` though the two forms should be equivalent. Does changing that...