Mike Shultz

@sreyemnayr is there anything you need to get this across the line?

@sreyemnayr sorry, missed your review request. Changes LGTM. @antazoey looks like there's still some test issues here? We need to set an infura key for this repo?

Confirmed tests pass, but I can't merge this because passing tests are required. @fubuloubu you want to merge this?

Some questions regarding the second option: Is the `walletId` returned by `IZionWalletServiceAPIs.getZionWalletId()` the same as `unique_id` as you'd get with `register()` in ZKMA? Trying to figure out how these two...

Ah, I completely forgot I sort of reimplemented this. Though I mostly recall copying it from TaskIQ's code. Still the same issue with threads though, no?

Never really been a fan of the `.env` file pattern. Secret settings that override env vars in a hidden file that sometimes accidentally get committed to the repo isn't super...

oops, just saw your reply. > ```python > class SilverbackConfig(BaseSettings): > BROKER_CLASS: str > BROKER_ARGS: dict[str, Any] = {} > ``` That's really interesting. Had no idea we could provide...

This all sounds good and seems pretty clear. Only thing I wonder is if we should either error or otherwise handle other return types for backwards compatibility and flexibility. Like...

> Add some test cases, and this is probably close to merge There are no tests yet in this repo. Perhaps that should be a separate project?

> In general, guidance should be that it only supports streaming new data events. > > The historical handling is useful for restarts, but I think when we finally utilize...