Michael Herold

Results 54 comments of Michael Herold
trafficstars

Good question, @dblock. I think that makes sense to me. Apologies for the delay in response!

Alright, digging in here. If I am understanding the intent of the benchmark, this is a clearer way to write it: Benchmark code ```ruby require 'set' require 'benchmark/memory' class Retainer...

Yeah, I think that would work. I doubt you'd ever have colliding names in a single app. Once I finish up what I'm currently working on at work, I'll have...

I'm also interested in this as part of what I'm trying to do in #246. Since it seems like the API key is really what matters for swapping agents, would...

Oo, I did not know that - I hadn't got that far into a code dive. Good to know, thank you!

The solution by @bbascarevic-tti is almost there. Here's what I ended up with; it seems to be working as expected: ```ruby if ENV['COVERAGE'] require 'simplecov' SimpleCov.start 'rails' end ENV['RAILS_ENV'] ||=...

@dblock When I was attempting to verify, I discovered that `StrictKeyAccess` doesn't work with `Mash`. See the following: ``` ruby class StrictMash < Hashie::Mash include Hashie::Extensions::StrictKeyAccess end h = StrictMash.new('a'...

Instead of a module, what would we think of making the handler injectable? Basically, the `else` case of the `case` statement is the "default handler". If we make that something...

@maxlinc Have you looked into this any further? I think it looks like a nice-to-have feature but I haven't ever worked with YARD handlers.

I'm just taking a look at this; sorry for the delay! In your original issue you're talking about a Trash but what you're dealing with here is a Dash with...