Michael Herold

Results 54 comments of Michael Herold

> So I'm planning to add a test that enforces a convention where all Hashie::Dash and extension private methods start with a triple underscore. I like this idea. I picked...

I've been thinking about this since I saw the report. As with the related issue with Mash (see #119 and #198 for the discussion), it comes down to the issue...

Bump @juozasg @cheerfulstoic Could you provide a reproducible example of this issue?

This is a good find, thank you for the test! I haven't spent much time thinking about how I want to rearchitect Dash. I won't be able to look into...

I added a minimal fix to this branch (and rebased it) as @BobbyMcWho and I discussed in #494. What do we think of this constraint? `#to_h` will return all properties...

Upon reading my last comment, we should take another look at this because I mention `#replace` like it's part of the `Hash` interface, which it isn't. I remember that making...

Could you please make a failing test and submit that as a pull request? That will help us diagnose what you're running into faster.

All Hash functionality is still there. All that means is that your injected item still responds to all of the Hash methods. We don't make any promises about subclasses of...

This is related to #432 and #434. I don't think that this is a change that we can make because it breaks the behavior of accessing deeply-nested Mashes. I'm not...

This looks reasonable. I'd be happy to accept a PR.