Matt Holt

Results 1518 comments of Matt Holt

Thanks for opening an issue! We'll look into this. It's not immediately clear to me what is going on, so I'll need your help to understand it better. Ideally, we...

That sounds like a bug in the SPA :thinking: especially if it can't be reproduced with curl. Having to use the browser to reproduce a bug is almost always indicative...

@odama626 It is a simple example. And it generally works because people aren't going to images directly, the web app is loading them as page subresources instead, and it wouldn't...

Yeah, I am not too worried about breakage at this point, since these are just test APIs, and we've never really formalized them or intended them to be used much....

Thanks for your question, and we're glad that you're using Caddy! So far, this doesn't look like a bug in Caddy. It looks more like a question about how to...

I actually meant to reply with the bug report template, haha. Thanks for opening an issue! We'll look into this. It's not immediately clear to me what is going on,...

Sounds good to me now. To clarify, is the consensus that this is ready to merge?

Thanks; this is probably still an improvement, but it would be nice to log when the host is initially discovered to be up, since active health checks should generally assume...

Thanks @hairyhenderson ! @cedricziel Would you be able to fix up the lint errors and make sure the tests pass, then we can get this in the next beta release?

Thanks for the commit! Looks like the order of the modified imports needs to be adjusted (for lint) and for tests, there's: ``` module_test.go:107: Invalid traceparent: --- FAIL: TestTracing_ServeHTTP_Propagation_Without_Initial_Headers (0.00s)...