caddy icon indicating copy to clipboard operation
caddy copied to clipboard

logging: Only log host is up status on change (fixes #6415)

Open klaxa opened this issue 1 year ago • 1 comments

This changes the behavior of logging to only log the host up-state on state changes.

I manually tested it in the setup I needed it in and I noticed that if the upstream is available immediately the line is not logged. That leads me to believe that the event is also not emitted? I am again unsure if this is the intended behavior.

Thanks!

klaxa avatar Jun 23 '24 12:06 klaxa

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 23 '24 12:06 CLAassistant

Thanks; this is probably still an improvement, but it would be nice to log when the host is initially discovered to be up, since active health checks should generally assume the host is down by default. That doesn't have to happen in this PR though.

mholt avatar Jul 03 '24 19:07 mholt