Nick Porcino

Results 510 comments of Nick Porcino

Every decrease noted indicates a missing unit test on the C/C++ side of things. Some strategies are to (1) add unit tests as part of the change, (2) start an...

Tests are awesome :) Why don't we go ahead and PR/land them separately, per your suggestion? I think they're ready.

Flagging for TSC, should probably close

The reason I mentioned CI is that I don't think we have expertise to maintain it on the team, so CI would be the only way we'd know if something...

since you submitted a PR, I assume you didn't find any other unwrapped things?

Everything here makes a lot of sense to me. I would want to keep the Ubuntu 20 target irrespective of using the aswf docker images, which I of course support....

I'd like if there were sentinel values in TimeRange for None, Never and Always With these rules embodied in union and intersection: ``` t U None = t t U...

Always example: A slate, stating SHOT MISSING, that appears in gaps not filled by anything else. In a user interface, it can be selected but not moved on its track....

and makeEmpty. Those were designed together with the box comparison algebra; i.e. all the operators should have the expected outcome when comparisons are made with other boxes.

ImathInterval.h ```cpp //------------------------------------------------------------------- // // class Imath::Interval // -------------------------------- // // An Interval has a min and a max and some miscellaneous // functions. It is basically a Box that...