Samuel Dobson

Results 11 comments of Samuel Dobson

utACK 7736efe2fabf4ad557eb328c79e9711d6adef9ef

re-ACK 7d25521dbfdc9d59576646b239ece55ec0d19ceb, no changes in squash

Do you know what the performance of a wallet would be like, in the case of a non-HD wallet being migrated?

> Probably worse. Almost certainly, that's why I'm asking :) It would be nice to know how much worse it would be

Approach NACK, I am a bit concerned about showing this to the user without them asking for it, as the error locations may not be correct. This may cause users...

Please see #536

I'm ~0 on this, as promag said, there is already an indicator. And spendable isn't the same as confirmed so I'm not convinced on that change either, Happy if other...

I don't think it's as safe to point out potential errors (which may be incorrect) unless the user asks for it.

> @Sjors Bech32 allows up to 4 typos without ambiguity. Only in detection, not in correction. We can only accurately correct two errors, and if more than that are made,...

@Sjors sorry, I may have worded things a bit confusingly. > Right, but we're not doing correction. We actually are. The error location code is actually computing the specific errors...