Mathieu Rochette
Mathieu Rochette
It would be useful and yes I guess having #1 would solves this however I have a few remarks: It's a bit of a PITA to parse those env variable...
now that there is an official php image based on alpine, I would recommend using it instead of building from scratch. the final image will be bigger but most of...
@mikehaertl I might take a look at this if things stays the same here. please tell if you start something before I do!
seems good to me! :+1:
@kusmierz if `ADD` works I'm fine with it. (dont' mind either way)
@clue about your [comment on versionning](https://github.com/clue/docker-adminer/pull/19#discussion_r59180165], with the docker hub we can provide both the latest and tagged release. in other images I'm doing it this way: - master branch...
I don't have more comment for this PR. it's ready as far as I'm concerned. it's up to @clue to either merge this into master or in another branch (to...
@clue do you think it can be merged once rebased (/ping @kusmierz ) ? or do you have other suggestions ?
@kusmierz I've made a few more comments, do you mind taking a look and rebasing the PR ? @clue is there still issues you'd like to be taken care for...
I agree with @clue I can't think of a reason to pin adminer to a specific version. Even if I had a very rare usecase where it would be needed,...