Nathaniel Caza
Nathaniel Caza
@mholt Absolutely. Most of the work for the protocol stuff is handled here (WriteTo should work for upstreams): https://godoc.org/github.com/mastercactapus/proxyprotocol We should work through things like how requests would work with...
Came across this while looking into several failing tests. It appears to cause our click events to be lost when running in CI (or locally with CPU throttling) if the...
@rbergmanaf Yeah, I could see using that; should it be optional or required? If optional, should it have a default? It seems odd to have something hang forever by default....
I like how `Wait` reads as well as implies what it does -- waits for a thing. Follow the _what_ rather than the _how_. I think `WaitForLine` is pretty clear,...
Context is a nice idea, is that used elsewhere or would this be a new syntax? As for defaulting, I think we should set the defaults for our "wait for...
Okay, that all sounds reasonable, and thanks for the insight on context. The last bit to clarify is regex parsing -- we can probably piggyback on `readString` and pass `/`...
Excellent, I'll switch this PR to a draft until I'm able to get those changes pushed up for review
@maaslalani ready for another look
For option 2, timeout should not be considered a viable path IMO; it would be dangerous to keep executing commands in an unknown state (e.g., `ssh` connection failed, it may...
^ put another way, the panic was intentional to be a "stop with error" for functions that don't return an error