Mars Hall
Mars Hall
Did you try upgrading it locally with `npm install [email protected]`? Does it deploy successfully? Please let us know your findings. Feel free to open a Pull Request for the upgrade.
@heruan this Heroku app generates the config JSON when it starts up with [this Node script](https://github.com/cobyism/ghost-on-heroku/blob/master/bin/create-config). It’s interesting that noone else has reported that problem yet, but if the config...
@AlvaroR156 it will not automatically upgrade on each deploy, unless you delete the `package-lock.json` file and set the dependency version for Ghost in `package.json` to a range such as `"2.1.x"`....
I think it's time to sunset this buildpack, then 🌆 because moving from `static.json` to a new web server configuration format will be breaking for many existing users. Vastly superior...
Hi @StevePavlin, This buildpack already supports what you’re trying to accomplish. See: [Runtime config with Environment Variables](https://github.com/mars/create-react-app-buildpack/blob/master/README.md#user-content-environment-variables)
This runtime configuration technique is well-founded, works for many folks including myself, so there must be something else causing this not to work: * Is the app really using this...
Also, * How did you install the js-runtime module? * Did you commit the `package.json` & `package-lock.json` with those updates?
Wow, great detective work on that ✨ Was the problematic cache control header something you added, or was it from the buildpack default? If it’s from the default, then I...
See [Runtime config variables](https://github.com/mars/create-react-app-buildpack/blob/master/README.md#user-content-compile-time-vs-runtime), a feature created specifically for this buildpack that eliminates the re-build step by injecting variables into the Javascript bundle as each Heroku dyno starts-up.
I see what you mean @marinav. Unfortunately I do not know much about how `PUBLIC_URL` is implemented. Maybe there's a clean way to solve this 🤷♂ I imagine working around...