Maxime Vdb comments

Results 56 comments of


                                            Maxime Vdb

Move create_user_permission to AdAccount

cc @daphyFB :)

Fix AsyncJob.nonzero job complete check

@rituparnamukherjee can we merge this too?

Fix AsyncJob.nonzero job complete check

can we include that in 2.7.2 version? it's pretty critic... cc @daphyFB @JiamingFB

Fix AsyncJob.nonzero job complete check

I don't see any branch referring to the 2.6 version on this repo (plus it's gonna be pretty quickly deprecated). I will port those changes to 2.7 and add tests...

`rasa init` misinterprets project path if it contains aliases such as '~'

Exalate commented: m-vdb commented: Hi @hobson, thanks a lot for your bug report. It looks like a valid bug, since [here](https://github.com/RasaHQ/rasa/blob/771cc4b4644f6b2f785c353304521ad69d68d8ae/rasa/cli/scaffold.py#L201-L220) we do not [expand](https://docs.python.org/3/library/pathlib.html#pathlib.Path.expanduser) the user home directory. You...

`rasa init` misinterprets project path if it contains aliases such as '~'

Exalate commented: m-vdb commented: @billy-horn do you have the link of the PR?

`rasa init` misinterprets project path if it contains aliases such as '~'

Exalate commented: m-vdb commented: great! yes please close the duplicate PR 🙏🏻

`rasa init` misinterprets project path if it contains aliases such as '~'

Exalate commented: m-vdb commented: Yes it is, there is a linked PR that appears to be stale at this stage, but could be good to look at for context 😄

`rasa test` to include action server

Exalate commented: m-vdb commented: For the record, decreasing priority to normal. We'll need time to scope the feature properly and we need to prioritise it together with our other initiatives...

`rasa test` to include action server

Exalate commented: m-vdb commented: It's currently planned for next year and unclear in which release it will go into. This is an issue we want to address holistically with other...