Lucas Koehler
Lucas Koehler
@colin-grant-work Thank you very much for the quick review. I pushed two commits to address the issues and add machine translations for the new command. I added the file picker...
@colin-grant-work That is a good point, thanks. I added the following limitation to the PR description: > - While an extracted webview resides in a secondary window, no contributed toolbar...
Hi @vince-fugnitto , thank you for your review :) I rebased the changes, applied your comments and added a new 1.26.0 section to the changelog
Hi @vince-fugnitto , thank you very much for your input. One question regarding "SecondaryWindowHandler Improvement": Did you observe this in electron or the browser? For electron this is already known...
> @lucas-koehler I observed it for electron, have you investigated as to why it does not work in electron but does in the browser? @vince-fugnitto When an external widget is...
> @lucas-koehler I believe the bug should be fixed for the mvp, it is likely due to a design problem of how we deal with windows in browser vs electron....
Hello @vince-fugnitto , I solved the electron focus issue by adding a new service `SecondaryWindowService` that handles creating and focussing the secondary windows. I preferred a separate service because the...
@vince-fugnitto I fixed the minor comments. I'll address the phosphor comment here for better visibility. > I believe this change will actually not work downstream, and means that the feature...
@vince-fugnitto I implemented the PhosphorJS fix by extending the generated webpack config for applications as discussed above. I tested this on Ubuntu and in a Windows VM and the patch...
@vince-fugnitto Thank you for reviewing and testing this again. I fixed your two small remarks :) I'll rebase and solve the `CHANGELOG.md` conflicts after the other reviews as I suspect...