Linas Vepštas

Results 1069 comments of Linas Vepštas

Yes, the internal-only definitions should be moved to `dict-common.h`! That would be perfect,

Yes, `MAX_SENTENCE` belongs in `link-includes.h`

Huh. I can't imagine. One problem is that we run the python tests before running the plain-C tests; I would like to know if the plain-C tests pass or not....

OK, So ... I checked. Indeed, I see exactly the same crash. It is occurring in a test of some brand-new code. Stubbing out that test: `YGenerationTestCase` lines 1099 to...

> I will then simply skip those two tests when targeting 32bit archs. Yes, please. Meanwhile: @ampli, I unleashed valgrind on this. I used the suppressions file here: https://github.com/opencog/atomspace/blob/master/lib/valgrind.python.suppressions and...

Fixed in commit d57493eed849eccd2c7ff6220d5997b24c2c7766 I will be spinning a version `5.10.2` if the Apple Homebrew folks verifiy the python install paths. (issue #1246) This new version will be very thin,...

When you say "succeeds" I assume you mean "succeeds when the python test is disabled" ... The armel, armhf and mipsel builds fail for exactly the same reason as the...

OK, so that is .. unexpected, and I cannot guess at the moment. Could you build with the following patch applied: ``` --- a/link-grammar/disjunct-utils.c +++ b/link-grammar/disjunct-utils.c @@ -441,6 +441,12 @@...

Oops, I forget the `fflush(stdout)` it will fail to print without that. Editing above post now.

... And is fixed in #1250 .. I will spin a 5.10.2 shortly.