Lionel Garcia

Results 47 comments of Lionel Garcia

Sorry for the very late answer on that. I think it would be worth adding that as a separate function (i.e. not in `gaia_radecs` but as `tmass_radecs`) with the same...

Also I think this should live in another module (definitely not in the `__init__.py` of the package)

I did the modifications in a new branch. I will need to PR to your fork @ppp-one and then, once merged, merge this one. This way you can appear as...

Hi @CosmoMatt, is there any plan to work on that in the near future? I would be happy to help if you have any interest in a pull request.

At the end we kept the limb darkened case separated from the fully non uniform case. As you suggest, surfaces are ignored when using [jaxoplanet.light_curves.limb_dark](https://jax.exoplanet.codes/en/latest/autoapi/jaxoplanet/light_curves/limb_dark/#module-jaxoplanet.light_curves.limb_dark). Do you think a warning...

@shashankdholakia, does that answer your question?

I opened [this issue](https://github.com/astro-informatics/s2fft/issues/191) on the s2fft repo to discuss that there! Just to be sure about the motives behind the static beta.

Just to keep a reference somewhere, here is the version with the padded `Ylm`: ```python import jax from jaxoplanet.experimental.starry import Ylm, rotation import numpy as np import jax.numpy as jnp...

Based on the answer from @CosmoMatt in `s2fft`'s issue [#191](https://github.com/astro-informatics/s2fft/issues/191), I tried the following implementation based on equation 8 of [this](https://arxiv.org/pdf/1110.6298.pdf) paper: ```python from s2fft.utils.rotation import generate_rotate_dls import jax.numpy as...

Thanks a lot for your answer @CosmoMatt! That is a really interesting avenue to consider anyway!