Lionel Garcia

Results 47 comments of Lionel Garcia

Hi @schackey, should I take over this one?

Thanks @mathtimm, can you pull from main in your branch? So that tests can run here

my bad this is auto_diff (maybe run auto_diff id diff is None?)

The first comparisons and explanatory measurements plot are now described in the exoplanet transit tutorial (part of #116)

That's a great addition indeed @schackey. Could you pull from the branch 3.0.0 (to fix #83), update your code and open a pull request?

Thanks a lot for the thorough work @EAlexJ! First of all I notice that most of the time stars in your images are no well detected due to lots of...

Yes I think that's definitely a good idea. I thought this was well made but its not at all. As you say: when using a [`PointSourceDetection`](https://prose.readthedocs.io/en/latest/md/generated/prose.blocks.detection.PointSourceDetection.html) block we should filter...

That's awesome, thanks! 🙏🏼

Thanks @szunigaf! > ```python > for sources, path in zip(SatDetection.get.values['sources'], SatDetection.get.values['path']): > long_sources = [source for source in sources if isinstance(source, TraceSource)] > long_sources = [source for source in long_sources...

Indeed! I think once #95 is done we will have a very elegant way to define how the sources properties are set! I think for the `TraceSource` it makes sense...