Oleksii Serdiuk
Oleksii Serdiuk
Looks like I forgot to put my 5 cents here :-) I think that automatically starting search is useful, however we should have some safeguard from flooding the server with...
> > As @leppa mentioned in the commit message, the delay is not needed for harmattan. > > Didn't commit c00922d change that, so that the textChanged signal is emitted...
Sounds like a race condition in loading list of calendars.
Aha. I have a theory. `QtConcurrent` runs `FahrplanCalendarManager::getCalendarsList()` in a separate thread. And from there it accesses object's members directly. When user exits `SettingsPage`, it gets deleted together with `FahrplanCalendarManager`....
Even better: ``` cpp if (m_future->isRunning()) { m_future.cancel(); m_future.waitForFinished(); } ```
> Perhaps disconnecting the signals of m_watcher will work. This won't work, because `getCalendarsList()` will still try to access `FahrplanCalendarManager`'s members (which don't exist anymore because manager was deleted). If...
Thanks for your suggestion. Needs some work, but it's doable.
Maybe, something like slide out options when search field gets activated? Or GPS-alike button on the left/right of the search field.
> - Improve qml performance by using createObject instead of creating them on startup One note regarding this. Main startup performance hogs are pages, due to their complexity and inclusion...
One more big thing I noticed from the code: every search for station/journey/timetabe leaks one instance of *ResultList: the object gets created by the parser but never gets deleted. Furthermore,...