Kevin Leung

Results 283 comments of Kevin Leung

1. I think redirect is as common as `ofString` or `ofBytes`. If they are included (and they are), probably redirect should be too. 2. We can simply write `'Redirected: $url...

Aright, never mind, I always keep in mind [this comment](https://github.com/haxetink/tink_typecrawler/issues/2#issuecomment-209889320): > Chances are that I will occasionally confront you with rather idiosyncratic decisions, that I just can't explain but "feel"...

Ok, that sounds reasonable. But seems that at this moment the topic has gone beyond my knowledge, I am open to learn more but I am afraid that I don't...

I prefer this to be handled in a Formatter. i.e. the macro should return the code comment as-is (and it has already done so)

In principal I think this is a good addition. Just please move the parsing logic to runtime and leave the macro untouched 😉 .

Yeah the default formatter was quickly thrown together so I could have _something_ to display. I am more than happy to see PRs that put in some advanced formatters.

I don't see the point of introducing new meta just to hold the documentation. The Haxe language itself already support that through field docs. You can put any strings in...

> @kevinresol do you mean that we use the docs to place everything relevant for the doc formatter and then have the formatter parse it and strip stuff out that...

@mikkelmr Thanks for the update. But can you leave the Macro.hx file unchanged please?