Kevin Leung

Results 283 comments of Kevin Leung

I'll keep this open because I still don't fully understand the problem

Before this PR, the way to work is to wrap every result in an extra `Option` so that one can emit None in eof. I believe this change can eliminate...

Main advantage is that those excluded tests are no longer required to be type-able, only valid syntax is enough. It is useful when in the middle of refactoring, etc.

First of all I need to understand `bounce()`, which I have been failed to do so.

Can we just get rid of `ClassBuilder` and pass the `Type` directly? And add `Types.getClassBuilder(type:Type)` for quick creation.

I think a quick fix is to not put the meta in the interface, but in the implementation. So make your interface like this: ```haxe interface RandomItemInput2 { function readPart():Surprise;...

`using tink.CoreApi;` is the recommended way to import everything from tink_core :smile:

btw let's keep this open until we fix the readme or something

I prefer having the user manually covert it via `Promised.ofJsPromise`

I don't use tink_await much nowadays and I am not sure if it is good to lift everything to a Promise implicitly. I will let others to comment.